• 
      

    Fix Backbone types for model constructor/initialize.

    Review Request #13845 — Created May 8, 2024 and submitted

    Information

    Spina
    master

    Reviewers

    The type definitions for Backbone models were typing the attributes
    argument to the model constructor, initialize, and preinitialize
    functions as being the attributes type, rather than a partial. This
    caused type errors any time a model was instantiated with a subset of
    attributes specified.

    Built the package and dropped the types file into my tree. Saw that I
    was no longer getting errors about instantiating models while passing
    attributes.

    Summary ID
    Fix Backbone types for model constructor/initialize.
    The type definitions for Backbone models were typing the attributes argument to the model constructor, initialize, and preinitialize functions as being the attributes type, rather than a partial. This caused type errors any time a model was instantiated with a subset of attributes specified. Testing Done: Built the package and dropped the types file into my tree. Saw that I was no longer getting errors about instantiating models while passing attributes.
    9c1d9967129badb755c9bde1265a57aa32b538d6
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (0cf6704)