• 
      
    Fish Trophy

    chipx86 got a fish trophy!

    Fish Trophy

    Avoid inheriting some styles in ButtonGroup and Menu.

    Review Request #13831 — Created May 6, 2024 and submitted — Latest diff uploaded

    Information

    Ink
    master

    Reviewers

    Depending on how these components are used, and what styles have been
    applied elsewhere, it's possible to break the appearance of both
    ButtonGroup and Menu.

    ButtonGroup assumed a default margin of 0, but if anything styled
    margins for a button-based selector, this could separate the buttons.
    It was very noticeable in a MenuButton. We now hard-code an explicit
    margin.

    Menu items assumed a text alignment of left, but similarly, it would
    end up inheriting an alignment. We now hard-code left.

    Verified this fixed issues with the Publish menu button in the Review
    Dialog.

    Commits

    Files