• 
      

    Update datagrids for dark mode and modern styling.

    Review Request #13809 — Created May 2, 2024 and submitted

    Information

    Djblets
    release-5.x

    Reviewers

    Historically, Djblets's datagrid styles have been quite ugly and
    somewhat broken. We've generally handled styling within Review Board
    itself, placing styles there partly for convenience and partly to match
    Review Board's look and feel. However, with Ink, we're now in a better
    position to improve the default styling.

    This change moves the styling to Ink, backports a lot of the Review
    Board styles to Djblets, and introduces dark mode.

    The styling is based on the (in-progress) Ink data table component. In
    the future, the plan is to rebuild datagrids on top of a more stable
    Ink foundation, but that's out of scope for now.

    Tested with Review Board, with an in-progress change that removes much
    of the overridden styling in favor of Djblets.

    This was tested on the dashboard, All Review Requests, Users, Groups,
    and the user page.

    Summary ID
    Update datagrids for dark mode and modern styling.
    Historically, Djblets's datagrid styles have been quite ugly and somewhat broken. We've generally handled styling within Review Board itself, placing styles there partly for convenience and partly to match Review Board's look and feel. However, with Ink, we're now in a better position to improve the default styling. This change moves the styling to Ink, backports a lot of the Review Board styles to Djblets, and introduces dark mode. The styling is based on the (in-progress) Ink data table component. In the future, the plan is to rebuild datagrids on top of a more stable Ink foundation, but that's out of scope for now.
    c545ecaefee4c22b769c1cac6041ec404992c135

    Description From Last Updated

    I find the black background here to be a bit too severe.

    daviddavid
    maubin
    1. Ship It!
    2. 
        
    david
    1. 
        
    2. Show all issues

      I find the black background here to be a bit too severe.

      1. We can tweak that, but it'll be in Ink. There isn't a good grey in the color palette for this, so we'll have to go beyond that.

    3. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-5.x (bc0bb5a)