• 
      

    Add dark mode for review entries, status updates, and change descriptions.

    Review Request #13801 — Created April 26, 2024 and submitted

    Information

    Review Board
    release-7.x

    Reviewers

    All the review-related content on the review request page now supports
    both light and dark modes. This includes reviews, change descriptions,
    status updates, and replies.

    There are some small color changes here and there, particularly to
    replies and to status updates, to better align with the palettes and
    provide better contrast. Change descriptions use diff theme colors for
    all insert/delete indications.

    The "Reply" and "Comment" links have been replaced with buttons, better
    helping indicate that they trigger an action when clicked, rather than
    taking the user to another page.

    Tested on a variety of reviews, replies, changes, and status updates I
    had locally.

    This will of course need more real-world testing.

    Summary ID
    Add dark mode for review entries, status updates, and change descriptions.
    All the review-related content on the review request page now supports both light and dark modes. This includes reviews, change descriptions, status updates, and replies. There are some small color changes here and there, particularly to replies and to status updates, to better align with the palettes and provide better contrast. Change descriptions use diff theme colors for all insert/delete indications. The "Reply" and "Comment" links have been replaced with buttons, better helping indicate that they trigger an action when clicked, rather than taking the user to another page.
    fe4388a4171853332c8dde40ab85c4903f5e6c8e

    Description From Last Updated

    Missing a screenshot for the dark mode version of status updates.

    maubinmaubin

    Maybe the "Fix it!" colour could be a bit darker?

    maubinmaubin
    maubin
    1. Looking good!!

    2. Show all issues

      Missing a screenshot for the dark mode version of status updates.

    3. Show all issues

      Maybe the "Fix it!" colour could be a bit darker?

      1. Since it's a small surface area, and an important state, I think it's fine to be bright here. Dark mode UIs still use brightness to convey importance in places, just as long as they're not dominant.

      2. Sounds good.

    4. 
        
    chipx86
    david
    1. Ship It!
    2. 
        
    maubin
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-7.x (41053f2)