Update the diff file index for dark mode, and fix rendering issues.

Review Request #13798 — Created April 25, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

The diff file index now displays with a darker palette on dark mode,
fitting in with the rest of the unified banner and the review request
box.

The styling is based on the Ink data table styling, with uses a black
background, helping the graphs really pop.

While working on this, I noticed that the dividing lines between the
rows were blurred slightly in light mode. This turned out to be due to
the scrolling placement (via translateY) and box height, which was
using sub-pixel positioning. By rounding both of these value, we align
everything to the pixel grid, keeping presentation sharp.

Icon and text alignment has also been fixed. This stood out a lot more
on dark mode.

Tested in both light and dark modes, docked and undocked.

Summary ID
Update the diff file index for dark mode, and fix rendering issues.
The diff file index now displays with a darker palette on dark mode, fitting in with the rest of the unified banner and the review request box. The styling is based on the Ink data table styling, with uses a black background, helping the graphs really pop. While working on this, I noticed that the dividing lines between the rows were blurred slightly in light mode. This turned out to be due to the scrolling placement (via `translateY`) and box height, which was using sub-pixel positioning. By rounding both of these value, we align everything to the pixel grid, keeping presentation sharp. Icon and text alignment has also been fixed. This stood out a lot more on dark mode.
5307e1566a6c69bac50314933505e2f1e2b8b86e

david
  1. Ship It!
  2. 
      
maubin
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-7.x (3b509e9)