Fix num_diffs in diffviewer context.

 






 

 


  Review Request #13791
  —
  Created April 25, 2024 and submitted 

 




















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-7.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
When I added the draft diffset to the diffsets list that's included in

the diffviewer page context, I missed that we were also adding 1 to the

num_diffs when there was a draft diffset. This was causing the diff

revision slider to show an extra revision that didn't exist.

 








  


 
 

  
Posted a change and saw that my draft said "Diff Revision 1 (Latest)"

instead of showing me a slider with two revisions.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Fix num_diffs in diffviewer context.
      
When I added the draft diffset to the diffsets list that's included in
the diffviewer page context, I missed that we were also adding 1 to the
num_diffs when there was a draft diffset. This was causing the diff
revision slider to show an extra revision that didn't exist.

Testing Done:
Posted a change and saw that my draft said "Diff Revision 1 (Latest)"
instead of showing me a slider with two revisions.

     


    		
    2f3c7aee74830f2f5a94304afcf15ec26a98f96f

   



  
 




 













 









 






  

 



















 




 




 














 





 

  

   




maubin




   

   







  

 



 

  


   

   

    
 
maubin


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  




  

   

    Change Summary:
   

   

    
Pushed to release-7.x (19fab1d)