• 
      

    Fix screenshot review UI comment de/serialization.

    Review Request #13768 — Created April 22, 2024 and submitted

    Information

    Review Board
    release-7.x

    Reviewers

    The comment serialization for the screenshot review UI was a bit broken,
    trying to pull the wrong keys out of the serialized comment dict.

    This change fixes that, and updates it so we're using our standard
    region comment serialization types for everything.

    Created a review request with a screenshot via the admin DB forms. Added
    a comment to that screenshot and published the review. Reopened the
    review UI and saw that the comment was properly loaded back into the
    review UI without any errors.

    Summary ID
    Fix screenshot review UI comment de/serialization.
    The comment serialization for the screenshot review UI was a bit broken, trying to pull the wrong keys out of the serialized comment dict. This change fixes that, and updates it so we're using our standard region comment serialization types for everything. Testing Done: Created a review request with a screenshot via the admin DB forms. Added a comment to that screenshot and published the review. Reopened the review UI and saw that the comment was properly loaded back into the review UI without any errors.
    dbe075a870f613ef18c8b4dc40ae5ab99b8cc4c1
    maubin
    1. Ship It!
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-7.x (5135174)