Summary

Break up sections in reviewbot 4 release notes.

Review Request #13758 — Created April 19, 2024 and submitted June 4, 2024, 9:51 p.m.

Information

Owner

david

Repository

ReviewBot

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

reviewbot

People

Description

This adds a "Compatibility" section at the top, separate from the
installation instructions. It also adds the missing contributors list.

Testing Done

Built HTML

Commits

Summary	ID
Break up sections in reviewbot 4 release notes. This adds a "Compatibility" section at the top, separate from the installation instructions. It also adds the missing contributors list. Testing Done: Built HTML	d8a758f355163cc0bda483d6001cf5f0329a3ad2

Issues

Description	From	Last Updated
The sections were right the other way around. We always have Installation first.	chipx86	June 4, 2024, 9:46 p.m.
I feel like the highlight of Review Board 7 gets a bit lost here. Can we make this into a …	chipx86	April 22, 2024, 9:57 a.m.
Typo, you said "Review Bot 7" instead of "Review Board 7".	maubin	April 23, 2024, 7:58 a.m.
We made changes in the other release notes to use a space around - for the ranges. Let's do that …	chipx86	June 4, 2024, 9:47 p.m.
The Review Board version range also needs the space.	chipx86	June 4, 2024, 9:50 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

docs/releasenotes/4.0.rst (Diff revision 1)

The issue has been resolved. Show all issues

I feel like the highlight of Review Board 7 gets a bit lost here. Can we make this into a standard bullet point form and make the summary the Review Board 7 support? Leave the rest of this to the description?

I also feel like we should mention which versions of Python/Review Board we deprecated (maybe a separate bullet point).

Commits:

	Summary	ID
	Break up sections in reviewbot 4 release notes. This adds a "Compatibility" section at the top, separate from the installation instructions. It also adds the missing contributors list. Testing Done: Built HTML	8eca29c6be70c38b7dff8264d6f2c1757decd378
	Break up sections in reviewbot 4 release notes. This adds a "Compatibility" section at the top, separate from the installation instructions. It also adds the missing contributors list. Testing Done: Built HTML	f8f0a511eceeb4b600fef8bbb215c64093c5c104

Diff:

Revision 2 (+36 -14)

Show changes

docs/releasenotes/4.0.rst

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

docs/releasenotes/4.0.rst (Diff revision 2)
The issue has been resolved. Show all issues
```
Typo, you said "Review Bot 7" instead of "Review Board 7".
```

Commits:

	Summary	ID
	Break up sections in reviewbot 4 release notes. This adds a "Compatibility" section at the top, separate from the installation instructions. It also adds the missing contributors list. Testing Done: Built HTML	f8f0a511eceeb4b600fef8bbb215c64093c5c104
	Break up sections in reviewbot 4 release notes. This adds a "Compatibility" section at the top, separate from the installation instructions. It also adds the missing contributors list. Testing Done: Built HTML	ec4bfe2c06c378502c673c08c8887f291b9d89ad

Diff:

Revision 3 (+36 -14)

Show changes

docs/releasenotes/4.0.rst

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

The sections were right the other way around. We always have Installation first.

docs/releasenotes/4.0.rst (Diff revision 3)

The issue has been resolved. Show all issues

We made changes in the other release notes to use a space around - for the ranges. Let's do that here as well.

Commits:

	Summary	ID
	Break up sections in reviewbot 4 release notes. This adds a "Compatibility" section at the top, separate from the installation instructions. It also adds the missing contributors list. Testing Done: Built HTML	ec4bfe2c06c378502c673c08c8887f291b9d89ad
	Break up sections in reviewbot 4 release notes. This adds a "Compatibility" section at the top, separate from the installation instructions. It also adds the missing contributors list. Testing Done: Built HTML	d8a758f355163cc0bda483d6001cf5f0329a3ad2

Diff:

Revision 4 (+36 -14)

Show changes

docs/releasenotes/4.0.rst

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

docs/releasenotes/4.0.rst (Diff revision 4)
The issue has been resolved. Show all issues
```
The Review Board version range also needs the space.
```

Status:: Completed
Change Summary:: Pushed to release-4.x (41fe704)