Summary

Set ReviewRequest.diffset_history to NULL on delete.

Review Request #13734 — Created April 16, 2024 and submitted April 19, 2024, 6 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

When a diffset history object is deleted, we don't actually want to
cascade and delete the review request. This change fixes that to set the
relation to NULL instead.

This is in preparation for a change that fixes it so we properly delete
the diffset history when deleting the review request (the opposite of
what the on_delete handler would previously do).

Testing Done

Ran the evolution.

Commits

Summary	ID
Set ReviewRequest.diffset_history to NULL on delete. When a diffset history object is deleted, we don't actually want to cascade and delete the review request. This change fixes that to set the relation to NULL instead. This is in preparation for a change that fixes it so we properly delete the diffset history when deleting the review request (the opposite of what the on_delete handler would previously do). Testing Done: Ran the evolution.	970067399920005e22da85d1dacb2aa2255ce733

Summary

Set ReviewRequest.diffset_history to NULL on delete.

When a diffset history object is deleted, we don't actually want to cascade and delete the review request. This change fixes that to set the relation to NULL instead. This is in preparation for a change that fixes it so we properly delete the diffset history when deleting the review request (the opposite of what the on_delete handler would previously do). Testing Done: Ran the evolution.

970067399920005e22da85d1dacb2aa2255ce733

Issues