• 
      

    Rename data-theme to data-ink-color-scheme.

    Review Request #13726 — Created April 14, 2024 and submitted

    Information

    Ink
    master

    Reviewers

    The name data-theme was a bit too generic, and implied that color
    schemes and themes were the same thing. That boxes us in in the future,
    and could clash with other uses.

    This change renames it to data-ink-color-scheme, which is far more
    clear on purpose, and can be reused amongst other themes in the future,
    if ones were introduced.

    It also adds "system" and "high-contrast" as options in Storybook,

    Tested in Storybook and in Review Board with accompanying changes.

    Summary ID
    Rename data-theme to data-ink-color-scheme.
    The name `data-theme` was a bit too generic, and implied that color schemes and themes were the same thing. That boxes us in in the future, and could clash with other uses. This change renames it to `data-ink-color-scheme`, which is far more clear on purpose, and can be reused amongst other themes in the future, if ones were introduced. It also adds "system" and "high-contrast" as options in Storybook,
    9a21d025850628a290758de489b7199aa8525781
    david
    1. Ship It!
    2. 
        
    maubin
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (1213618)