Add file attachment comments to diff comments hint.
Review Request #13684 — Created April 1, 2024 and submitted
Now that we have file attachment comments showing up as part of the
diff, we also want to include that data in the diff comments hint. This
change adds that in, expanding the file attachment comment helper
function to return some additional data useful for this.This simplifies the client side a bit by allowing the tip revision to be
null, for the case where we don't want the URL to include
?tip-commit-id
.
Created a draft review with a bunch of comments on files in various diff
revisions, interdiff revisions, and commit ranges (as well as some
comments on regular file attachments). Saw that the diff comment hint
correctly contained all the revisions and that clicking on everything
loaded the correct page.
Summary | ID |
---|---|
9aab363bbd3f3b593bd6e674dfd5e8cda720526e |
Description | From | Last Updated |
---|---|---|
Can we set this alphabetically? |
chipx86 |
- Commits:
-
Summary ID 8fa9410cde8d30135e260aed830cab291eb03ff6 9aab363bbd3f3b593bd6e674dfd5e8cda720526e - Diff:
-
Revision 2 (+202 -68)