• 
      

    Don't record changed file captions for diff file attachments.

    Review Request #13673 — Created April 10, 2024 and submitted

    Information

    Review Board
    release-7.x

    Reviewers

    Publishing updates to diffs that included file attachments was showing a
    "File Captions" field in the change description that included captions
    for every file in every commit in the new diff. These files are already
    listed in the "Diff" field, and they don't have editable captions at all.

    This change filters them out when we're deciding what to record in the
    change description.

    Posted an update to a change that included binary files. Saw that there
    was no longer a bunch of "File Caption" changes in the change description.

    Summary ID
    Don't record changed file captions for diff file attachments.
    Publishing updates to diffs that included file attachments was showing a "File Captions" field in the change description that included captions for every file in every commit in the new diff. These files are already listed in the "Diff" field, and they don't have editable captions at all. This change filters them out when we're deciding what to record in the change description. Testing Done: Posted an update to a change that included binary files. Saw that there was no longer a bunch of "File Caption" changes in the change description.
    120ee59d75d812c727da2c90845e3ac3afd2af44
    maubin
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-7.x (16a8a4f)