Update UI for the comments hint.

 






 

 


  Review Request #13672
  —
  Created March 27, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-7.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change ports the comments hint model and view to TypeScript, and

updates the UI to include the new commit range information. Along with

this, the implementation has been simplified a bit to attach event

handlers individually to each item in the list, rather than having a

generic event handler and setting data on the list items.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Viewed a diff while having a review that had comments on lots of
    
  different revisions/interdiffs/commits. Saw that the comment hint
    
  correctly showed all of the revisions that had draft comments, and
    
  that clicking on all of them correctly loaded the associated revision.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3
4

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Update UI for the comments hint.
     
This change ports the comments hint model and view to TypeScript, and
updates the UI to include the new commit range information. Along with
this, the implementation has been simplified a bit to attach event
handlers individually to each item in the list, rather than having a
generic event handler and setting data on the list items.

Testing Done:
- Ran js-tests.
- Viewed a diff while having a review that had comments on lots of
  different revisions/interdiffs/commits. Saw that the comment hint
  correctly showed all of the revisions that had draft comments, and
  that clicking on all of them correctly loaded the associated revision.

    

   
  		
  97ddab26f7bf8ac3bdff861403d0de94c70e9849
  David Trowbridge
 


 
  
 
 
  
   
    

     Update UI for the comments hint.
     
This change ports the comments hint model and view to TypeScript, and
updates the UI to include the new commit range information. Along with
this, the implementation has been simplified a bit to attach event
handlers individually to each item in the list, rather than having a
generic event handler and setting data on the list items.

Testing Done:
- Ran js-tests.
- Viewed a diff while having a review that had comments on lots of
  different revisions/interdiffs/commits. Saw that the comment hint
  correctly showed all of the revisions that had draft comments, and
  that clicking on all of them correctly loaded the associated revision.

    

   
  		
  5ce1f7c84b281fe76b69d62b2a1518309b1206ea
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      package-lock.json
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/dependencies.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/package.json
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/views/review_request_detail.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/models/diffViewerPageModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/diffCommentsHintView.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...