Compile Ink's babel-preset to a CommonJS module.

 






 

 


  Review Request #13669
  —
  Created March 26, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Ink
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  beanbag-misc
 









 
 

  
 






 








 





  


 
 

  
We were shipping babel-preset as an ESM module, which wasn't safe and

could trigger errors during usage in Babel.


We now compile this as a CommonJS target, ensuring it has the widest

compatibility possible.

 








  


 
 

  
Built Ink and then activated the preset in Review Board's Babel

configuration. Verified that the preset's craft and paint template

tags were properly compiled in the generated code.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Compile Ink's babel-preset to a CommonJS module.
     
We were shipping `babel-preset` as an ESM module, which wasn't safe and
could trigger errors during usage in Babel.

We now compile this as a CommonJS target, ensuring it has the widest
compatibility possible.

    

   
  		
  9a64795786a41002654a1103b53ba58704aa2421
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      package.json
     
    

   
  

 



 

  

   
    

     
      
      rollup.config.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...