Groups page starred crash

Review Request #1362 — Created Jan. 26, 2010 and submitted — Latest diff uploaded

Information

Review Board

Reviewers

The groups page at /groups/ has a problem. You can even see it here at http://reviews.reviewboard.org/groups/
The fix is pretty straight forward, I'm pretty sure this regression is due to the optimizations done to the djblets datagrid view.

Error as follows
AttributeError at /groups/
'NoneType' object has no attribute 'starred_groups'
Request Method:	GET
Request URL:	http://reviews.reviewboard.org/groups/
Exception Type:	AttributeError
Exception Value:	
'NoneType' object has no attribute 'starred_groups'
Exception Location:	/usr/lib/python2.5/site-packages/ReviewBoard-1.1alpha3.dev_20100113-py2.5.egg/reviewboard/reviews/templatetags/reviewtags.py in render_star, line 504
Python Executable:	/usr/bin/python
Python Version:	2.5.2
Python Path:	['/var/www/reviews.reviewboard.org/conf', '/usr/lib/python2.5/site-packages/python_memcached-1.40-py2.5.egg', '/usr/lib/python2.5/site-packages/BuildBatter-0.1-py2.5.egg', '/usr/lib/python2.5/site-packages/virtualenv-1.3-py2.5.egg', '/usr/lib/python2.5/site-packages/django_evolution-0.0.0-py2.5.egg', '/usr/lib/python2.5/site-packages/flup-1.0.1-py2.5.egg', '/usr/lib/python2.5/site-packages/docutils-0.5-py2.5.egg', '/usr/lib/python2.5/site-packages/Jinja2-2.1.1-py2.5-linux-i686.egg', '/usr/lib/python2.5/site-packages/setuptools-0.6c9-py2.5.egg', '/usr/lib/python2.5/site-packages/JCC-2.1-py2.5-linux-i686.egg', '/usr/lib/python2.5/site-packages/pytz-2009f-py2.5.egg', '/usr/lib/python2.5/site-packages/gitosis-0.2-py2.5.egg', '/usr/lib/python2.5/site-packages/buildbot-0.7.10p1-py2.5.egg', '/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg', '/usr/lib/python2.5/site-packages/Sphinx-0.6.3-py2.5.egg', '/usr/lib/python2.5/site-packages/recaptcha_client-1.0.5-py2.5.egg', '/usr/lib/python2.5/site-packages/paramiko-1.7.6-py2.5.egg', '/usr/lib/python2.5/site-packages/Pygments-1.1.1-py2.5.egg', '/usr/lib/python2.5/site-packages/pycrypto-2.0.1-py2.5-linux-i686.egg', '/usr/lib/python2.5/site-packages/ReviewBoard-1.1alpha3.dev_20100113-py2.5.egg', '/usr/lib/python2.5/site-packages/Djblets-0.5.7alpha0.dev_20100113-py2.5.egg', '/usr/lib/python25.zip', '/usr/lib/python2.5', '/usr/lib/python2.5/plat-linux2', '/usr/lib/python2.5/lib-tk', '/usr/lib/python2.5/lib-dynload', '/usr/local/lib/python2.5/site-packages', '/usr/lib/python2.5/site-packages', '/usr/lib/python2.5/site-packages/PIL', '/var/lib/python-support/python2.5']
Server time:	Tue, 26 Jan 2010 13:00:57 -0800

Starring still does not work, but it is also broken in 1.0.5.1. I thought it had to do with obj.name being used instead of obj.id, but it seems like maybe some of the JS is missing. I will have to leave that to someone else.
Groups, now work fine, starred and unstarred with over 30+ groups on 3 different user accounts. 

Adding new stars does not seem to work. (still looking into why). But this at least fixes the crash.