flake8
failed.
JSHint
passed.
Review Request #13611 — Created March 4, 2024 and discarded
When we first implemented the datagrids, it was the case that assigning
a list value into a TextField would serialize it as a comma-separated
list of the values in the list. This is no longer the case, and setting
the datagrid columns would end up saving as a list repr, which wasn't
parsable when loading the value back out.This change fixes it so we explicitly join the datagrid columns when
saving them back to the profile, and adds some unit tests to make sure
that saving the columns and sort order work correctly.
Summary | ID |
---|---|
4752b2b98f43f7faecb9c79678aff2ec900b9c79 |
Description | From | Last Updated |
---|---|---|
'typing.Optional' imported but unused Column: 1 Error code: F401 |
reviewbot |
Summary | ID | |
---|---|---|
203f1eade5b78bf70d607d3922d11c2c0d8ff01b | ||
4752b2b98f43f7faecb9c79678aff2ec900b9c79 |
Revision 2 (+132 -4)