Summary

Add get_file_content APIs for Perforce and improve revision range diffs.

Review Request #13593 — Created March 1, 2024 and submitted March 26, 2024, 11:20 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Testing Done


Posted a variety of submitted and pending changesets, including binary

  files.
Verified that the revision information for modified files was present

  in the diff headers when posting submitted changesets.
Ran unit tests.

Commits

Summary	ID
Add get_file_content APIs for Perforce and improve revision range diffs. This change makes two improvements to the Perforce client backend in RBTools. First, this implements the new get_file_content and get_file_size APIs for use with uploading binary files to diffs. Second, this plumbs through the tip revision for each file to the diff method so that we can include it in the file headers. This was important when posting submitted changesets so that we would have revision information for the modified file as well as the original. Testing Done: - Posted a variety of submitted and pending changesets, including binary files. - Verified that the revision information for modified files was present in the diff headers when posting submitted changesets. - Ran unit tests.	4fed98549a6a3a25826f2bc66273985fc44736f3

Summary

Add get_file_content APIs for Perforce and improve revision range diffs.

This change makes two improvements to the Perforce client backend in RBTools. First, this implements the new get_file_content and get_file_size APIs for use with uploading binary files to diffs. Second, this plumbs through the tip revision for each file to the diff method so that we can include it in the file headers. This was important when posting submitted changesets so that we would have revision information for the modified file as well as the original. Testing Done: - Posted a variety of submitted and pending changesets, including binary files. - Verified that the revision information for modified files was present in the diff headers when posting submitted changesets. - Ran unit tests.

4fed98549a6a3a25826f2bc66273985fc44736f3

Issues

Description	From	Last Updated
I know it's internal, but can you add Version Added to these? I've often found them useful when trying to …	chipx86	March 4, 2024, 7:37 p.m.
This could be an f-string.	chipx86	March 4, 2024, 7:36 p.m.
local variable 'content' is assigned to but never used Column: 13 Error code: F841	reviewbot	March 18, 2024, 4:03 p.m.
local variable 'content' is assigned to but never used Column: 13 Error code: F841	reviewbot	March 18, 2024, 4:03 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

rbtools/clients/perforce.py (Diff revision 1)

The issue has been resolved. Show all issues

I know it's internal, but can you add Version Added to these? I've often found them useful when trying to backport code or diagnose things for customers. Gives me a starting point when trying to figure out where things originated.

rbtools/clients/perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This could be an f-string.
```

Commits:

	Summary	ID
	Add get_file_content APIs for Perforce and improve revision range diffs. This change makes two improvements to the Perforce client backend in RBTools. First, this implements the new get_file_content and get_file_size APIs for use with uploading binary files to diffs. Second, this plumbs through the tip revision for each file to the diff method so that we can include it in the file headers. This was important when posting submitted changesets so that we would have revision information for the modified file as well as the original. Testing Done: - Posted a variety of submitted and pending changesets, including binary files. - Verified that the revision information for modified files was present in the diff headers when posting submitted changesets. - Ran unit tests.	a54405e8f130a098eafec48368df0d7ae8d5ab52
	Add get_file_content APIs for Perforce and improve revision range diffs. This change makes two improvements to the Perforce client backend in RBTools. First, this implements the new get_file_content and get_file_size APIs for use with uploading binary files to diffs. Second, this plumbs through the tip revision for each file to the diff method so that we can include it in the file headers. This was important when posting submitted changesets so that we would have revision information for the modified file as well as the original. Testing Done: - Posted a variety of submitted and pending changesets, including binary files. - Verified that the revision information for modified files was present in the diff headers when posting submitted changesets. - Ran unit tests.	032657fcad316fd6645b7361a6475922ee9610f1

Diff:

Revision 2 (+236)

Show changes

rbtools/clients/perforce.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Add unit tests for new APIs

Commits:

	Summary	ID
	Add get_file_content APIs for Perforce and improve revision range diffs. This change makes two improvements to the Perforce client backend in RBTools. First, this implements the new get_file_content and get_file_size APIs for use with uploading binary files to diffs. Second, this plumbs through the tip revision for each file to the diff method so that we can include it in the file headers. This was important when posting submitted changesets so that we would have revision information for the modified file as well as the original. Testing Done: - Posted a variety of submitted and pending changesets, including binary files. - Verified that the revision information for modified files was present in the diff headers when posting submitted changesets. - Ran unit tests.	032657fcad316fd6645b7361a6475922ee9610f1
	Add get_file_content APIs for Perforce and improve revision range diffs. This change makes two improvements to the Perforce client backend in RBTools. First, this implements the new get_file_content and get_file_size APIs for use with uploading binary files to diffs. Second, this plumbs through the tip revision for each file to the diff method so that we can include it in the file headers. This was important when posting submitted changesets so that we would have revision information for the modified file as well as the original. Testing Done: - Posted a variety of submitted and pending changesets, including binary files. - Verified that the revision information for modified files was present in the diff headers when posting submitted changesets. - Ran unit tests.	9f33650e5163251f25ba0c8d9c352829457820fe

Diff:

Revision 3 (+404 -2)

Show changes

	rbtools/clients/perforce.py
	rbtools/clients/tests/test_p4.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/clients/tests/test_p4.py (Diff revision 3)

The issue has been dropped. Show all issues

local variable 'content' is assigned to but never used

Column: 13
Error code: F841

rbtools/clients/tests/test_p4.py (Diff revision 3)

The issue has been dropped. Show all issues

local variable 'content' is assigned to but never used

Column: 13
Error code: F841

Commits:

	Summary	ID
	Add get_file_content APIs for Perforce and improve revision range diffs. This change makes two improvements to the Perforce client backend in RBTools. First, this implements the new get_file_content and get_file_size APIs for use with uploading binary files to diffs. Second, this plumbs through the tip revision for each file to the diff method so that we can include it in the file headers. This was important when posting submitted changesets so that we would have revision information for the modified file as well as the original. Testing Done: - Posted a variety of submitted and pending changesets, including binary files. - Verified that the revision information for modified files was present in the diff headers when posting submitted changesets. - Ran unit tests.	9f33650e5163251f25ba0c8d9c352829457820fe
	Add get_file_content APIs for Perforce and improve revision range diffs. This change makes two improvements to the Perforce client backend in RBTools. First, this implements the new get_file_content and get_file_size APIs for use with uploading binary files to diffs. Second, this plumbs through the tip revision for each file to the diff method so that we can include it in the file headers. This was important when posting submitted changesets so that we would have revision information for the modified file as well as the original. Testing Done: - Posted a variety of submitted and pending changesets, including binary files. - Verified that the revision information for modified files was present in the diff headers when posting submitted changesets. - Ran unit tests.	4fed98549a6a3a25826f2bc66273985fc44736f3

Diff:

Revision 4 (+596 -2)

Show changes

	rbtools/clients/perforce.py
	rbtools/clients/tests/test_p4.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (c22baac)