flake8
passed.
JSHint
passed.
Review Request #13586 — Created Feb. 28, 2024 and submitted
Spina 3.0 introduced a
Result<T> = Backbone._Result<T>
alias in
objects.ts
, but it failed to importBackbone
. This led to an
assumption thatBackbone
was a global type that should not be
interfered with, and thus renamed theBackbone
type in the resulting
d.ts
file ttoBackbone$1
.This broke typing in some ways.
Result<T>
no longer had a type (since
it didn't know whatBackbone._Result<T>
was in this context), and the
difference betweenBackbone
andBackbone$1
led to issues resolving
types of some attributes in subclasses of our base classes.This change adds the missing import, fixing up the types.
Unit tests pass.
Verified this fixed typing issues in Ink.
Summary | ID |
---|---|
efb3c093e5f9255bbe9d74124a8d8b9ac233c5e3 |