• 
      

    Move perforce revision parsing into the diff parser.

    Review Request #13581 — Created Feb. 27, 2024 and submitted

    Information

    Review Board
    release-7.x

    Reviewers

    Similar to what I recently did for SVN, this moves the Perforce revision
    parsing (the thing that splits //depot/path#revision) into the diff
    parser. This also will optimistically try to do that same parsing for
    the modified file, in the case where we're posting a revision range of
    already-submitted changesets.

    • Ran unit tests.
    • Posted a variety of changes across various revision ranges, both for
      submitted changes and pending changesets.
    Summary ID
    Move perforce revision parsing into the diff parser.
    Similar to what I recently did for SVN, this moves the Perforce revision parsing (the thing that splits `//depot/path#revision`) into the diff parser. This also will optimistically try to do that same parsing for the modified file, in the case where we're posting a revision range of already-submitted changesets. Testing Done: - Ran unit tests. - Posted a variety of changes across various revision ranges, both for submitted changes and pending changesets.
    38d90d7f48030433409dcd78733e571019cbf071
    maubin
    1. Ship It!
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-7.x (1828fce)