• 
      

    Fix BaseView.rendered state, and add new rendering/rendered events.

    Review Request #13551 — Created Feb. 18, 2024 and submitted

    Information

    Spina
    master

    Reviewers

    BaseView.rendered was set after onInitialRender() completed, but
    before onRender() completed. This could be a bit non-intuitive, and
    limited what information onRender() had available. We now set this
    after onRender() completes.

    This also adds two new events: rendering and rendered. Both take an
    object parameter with an initialRender boolean. Consumers can listen
    to this to perform actions pre/post-render, making it easier to perform
    actions at the right point in the render stages in a consistent way.

    Unit tests pass.

    Made use of the new signals in some in-progress work.

    Summary ID
    Fix BaseView.rendered state, and add new rendering/rendered events.
    `BaseView.rendered` was set after `onInitialRender()` completed, but before `onRender()` completed. This could be a bit non-intuitive, and limited what information `onRender()` had available. We now set this after `onRender()` completes. This also adds two new events: `rendering` and `rendered`. Both take an object parameter with an `initialRender` boolean. Consumers can listen to this to perform actions pre/post-render, making it easier to perform actions at the right point in the render stages in a consistent way.
    79ac52f2e7a1da99a446b690fc42bfa6f7132006
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (1cca234)