Make onRender() and onInitialRender() protected, not public.

 






 

 


  Review Request #13550
  —
  Created Feb. 18, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Spina
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  beanbag-misc
 









 
 

  
 






 








 





  


 
 

  
When first designing Spina, we made onRender() and onInitialRender()

public methods, when they really should have been protected methods,

discouraging any use outside of subclasses.


This changes them to protected. As this is an interface change, we'll be

making this release 3.0 instead of 2.1. That's a better fit for some of

the other changes introduced in this release anyway. A future change

will formalize the version bump.

 








  


 
 

  
Unit tests pass.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Make onRender() and onInitialRender() protected, not public.
     
When first designing Spina, we made `onRender()` and `onInitialRender()`
public methods, when they really should have been protected methods,
discouraging any use outside of subclasses.

This changes them to protected. As this is an interface change, we'll be
making this release 3.0 instead of 2.1. That's a better fit for some of
the other changes introduced in this release anyway. A future change
will formalize the version bump.

    

   
  		
  2542e6bc7c5755ddc749c2a73bbc857f1edd5449
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      src/view.ts
     
    

   
  

 



 

  

   
    

     
      
      src/tests/baseViewTests.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...