Fish Trophy

  
david got a fish trophy!

  
  Fish Trophy

 







 





 

 

  

  

 




  







 




  


 
 

  
Convert reviewable views to TypeScript/spina.

 






 

 


  Review Request #13531
  —
  Created Feb. 12, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change converts the reviewable views (and associated utility views)

to TypeScript/spina.


While I was here I disconvered that one of the tests for DiffReviewable

was intended to be async, but didn't take a done callback and was

therefore skipping the meat of the test. After fixing that, it became

evident that the implementation of the test was broken, so it's been

rewritten.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Smoke tested reviewing diffs and file attachments.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3
4

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Convert reviewable views to TypeScript/spina.
     
This change converts the reviewable views (and associated utility views)
to TypeScript/spina.

While I was here I disconvered that one of the tests for DiffReviewable
was intended to be async, but didn't take a `done` callback and was
therefore skipping the meat of the test. After fixing that, it became
evident that the implementation of the test was broken, so it's been
rewritten.

Testing Done:
- Ran js-tests.
- Smoke tested reviewing diffs and file attachments.

    

   
  		
  49e790ad0f6a12bf7c3092912ea1b2d2d1b2ee66
  David Trowbridge
 


 
  
 
 
  
   
    

     Convert reviewable views to TypeScript/spina.
     
This change converts the reviewable views (and associated utility views)
to TypeScript/spina.

While I was here I disconvered that one of the tests for DiffReviewable
was intended to be async, but didn't take a `done` callback and was
therefore skipping the meat of the test. After fixing that, it became
evident that the implementation of the test was broken, so it's been
rewritten.

Testing Done:
- Ran js-tests.
- Smoke tested reviewing diffs and file attachments.

Reviewed at https://reviews.reviewboard.org/r/13531/

    

   
  		
  cd970afea3e126fd29d56391310d41c07118f763
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/abstractReviewableView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/diffReviewableView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/imageReviewableView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/textCommentRowSelectorView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/centeredElementManager.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...