david got a fish trophy!
Convert reviewable views to TypeScript/spina.
Review Request #13531 — Created Feb. 12, 2024 and submitted — Latest diff uploaded
This change converts the reviewable views (and associated utility views)
to TypeScript/spina.While I was here I disconvered that one of the tests for DiffReviewable
was intended to be async, but didn't take adonecallback and was
therefore skipping the meat of the test. After fixing that, it became
evident that the implementation of the test was broken, so it's been
rewritten.
- Ran js-tests.
- Smoke tested reviewing diffs and file attachments.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 4. See what's changed.
orig
1
2
3
4
Commits
Files
| reviewboard/staticbundles.py |
|---|
| reviewboard/static/rb/js/reviews/index.ts |
|---|
| reviewboard/static/rb/js/views/abstractReviewableView.es6.js |
|---|
| reviewboard/static/rb/js/reviews/views/diffFileIndexView.ts |
|---|
| reviewboard/static/rb/js/diffviewer/views/diffReviewableView.es6.js |
|---|
| reviewboard/static/rb/js/reviews/views/diffViewerPageView.ts |
|---|
| reviewboard/static/rb/js/views/dummyReviewableView.es6.js |
|---|
| reviewboard/static/rb/js/reviews/views/fileAttachmentReviewableView.ts |
|---|
| reviewboard/static/rb/js/views/imageReviewableView.es6.js |
|---|
| reviewboard/static/rb/js/reviews/views/markdownReviewableView.ts |
|---|
| reviewboard/static/rb/js/views/textBasedReviewableView.es6.js |
|---|
| reviewboard/static/rb/js/views/textCommentRowSelector.es6.js |
|---|
| reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.es6.js |
|---|
| reviewboard/static/rb/js/reviews/views/tests/diffViewerPageViewTests.ts |
|---|
| reviewboard/static/rb/js/reviews/views/tests/index.ts |
|---|
| reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js |
|---|
| reviewboard/static/rb/js/ui/index.ts |
|---|
| reviewboard/static/rb/js/ui/views/centeredElementManager.es6.js |
|---|
| reviewboard/static/rb/js/views/fileAttachmentReviewableView.es6.js |
|---|
| reviewboard/static/rb/js/views/markdownReviewableView.es6.js |
|---|