Convert reviewable models to TypeScript/spina.

 






 

 


  Review Request #13530
  —
  Created Feb. 7, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change converts the *Reviewable models to TypeScript. While I was

in here I also removed some deprecated callbacks-style invocation inside

of the DiffReviewable.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Smoke tested reviewing file attachments and diffs.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Convert reviewable models to TypeScript/spina.
     
This change converts the *Reviewable models to TypeScript. While I was
in here I also removed some deprecated callbacks-style invocation inside
of the DiffReviewable.

Testing Done:
- Ran js-tests.
- Smoke tested reviewing file attachments and diffs.

    

   
  		
  dd0563aef4644b7fedc6b6e52b951a8f697249ac
  David Trowbridge
 


 
  
 
 
  
   
    

     Convert reviewable models to TypeScript/spina.
     
This change converts the *Reviewable models to TypeScript. While I was
in here I also removed some deprecated callbacks-style invocation inside
of the DiffReviewable.

Testing Done:
- Ran js-tests.
- Smoke tested reviewing file attachments and diffs.

Reviewed at https://reviews.reviewboard.org/r/13530/

    

   
  		
  c7a3bf9643eb23324ba35e369d6cf71709403b4f
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/models/abstractReviewableModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/models/diffReviewableModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/models/dummyReviewableModel.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...