Summary

Convert reviewable models to TypeScript/spina.

Review Request #13530 — Created Feb. 7, 2024 and submitted Feb. 20, 2024, 8:42 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change converts the *Reviewable models to TypeScript. While I was
in here I also removed some deprecated callbacks-style invocation inside
of the DiffReviewable.

Testing Done


Ran js-tests.
Smoke tested reviewing file attachments and diffs.

Commits

Summary	ID
Convert reviewable models to TypeScript/spina. This change converts the *Reviewable models to TypeScript. While I was in here I also removed some deprecated callbacks-style invocation inside of the DiffReviewable. Testing Done: - Ran js-tests. - Smoke tested reviewing file attachments and diffs. Reviewed at https://reviews.reviewboard.org/r/13530/	c7a3bf9643eb23324ba35e369d6cf71709403b4f

Issues

Description	From	Last Updated
These should all be removed.	chipx86	Feb. 15, 2024, 7:44 p.m.
Missing docs.	chipx86	Feb. 15, 2024, 7:45 p.m.
I think we can infer this type by doing: class AbstractReviewable< TAttributes extends AbstractReviewableAttrs = AbstractReviewableAttrs, TCommentBlockType extends AbstractCommentBlock<TCommentBlockAttrs>, TCommentBlockAttrs …	chipx86	Feb. 15, 2024, 7:47 p.m.
Two blank lines.	chipx86	Feb. 15, 2024, 7:47 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/static/rb/js/reviews/models/diffReviewableModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

These should all be removed.

reviewboard/static/rb/js/reviews/models/abstractReviewableModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

Missing docs.

reviewboard/static/rb/js/reviews/models/abstractReviewableModel.ts (Diff revision 1)

The issue has been dropped. Show all issues

I think we can infer this type by doing:

class AbstractReviewable<
    TAttributes extends AbstractReviewableAttrs = AbstractReviewableAttrs,
    TCommentBlockType extends AbstractCommentBlock<TCommentBlockAttrs>,
    TCommentBlockAttrs
> extends ... {
    createCommentBlock(attrs: TCommentBlockAttrs) { ... }
}

david Feb. 15, 2024, 7:48 p.m.

That doesn't work. I've been banging my head against this for a while. It's on my radar to circle back and try to improve it.

chipx86 Feb. 19, 2024, 5:57 p.m.

Yeah it doesn't. I tried to bring this into Spina and it didn't work. But there's some stuff in TypeScript 5+ that may make some of this possible. On my to-do list to play with.

reviewboard/static/rb/js/reviews/models/dummyReviewableModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

Two blank lines.

Commits:

	Summary	ID
	Convert reviewable models to TypeScript/spina. This change converts the *Reviewable models to TypeScript. While I was in here I also removed some deprecated callbacks-style invocation inside of the DiffReviewable. Testing Done: - Ran js-tests. - Smoke tested reviewing file attachments and diffs.	dd0563aef4644b7fedc6b6e52b951a8f697249ac
	Convert reviewable models to TypeScript/spina. This change converts the *Reviewable models to TypeScript. While I was in here I also removed some deprecated callbacks-style invocation inside of the DiffReviewable. Testing Done: - Ran js-tests. - Smoke tested reviewing file attachments and diffs. Reviewed at https://reviews.reviewboard.org/r/13530/	c7a3bf9643eb23324ba35e369d6cf71709403b4f

Diff:

Revision 2 (+1166 -870)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/models/dummyReviewableModel.es6.js
	reviewboard/static/rb/js/models/fileAttachmentReviewableModel.es6.js
	reviewboard/static/rb/js/models/imageReviewableModel.es6.js
	reviewboard/static/rb/js/models/screenshotReviewableModel.es6.js
	reviewboard/static/rb/js/models/textBasedReviewableModel.es6.js
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/models/abstractReviewableModel.es6.js
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (cdc4055)