Fix defaults() to always be static.

 






 

 


  Review Request #13517
  —
  Created Feb. 1, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
We had a number of classes where defaults was not properly defined as

static. This broke when updating to the newer spina that fixes

prototypeAttrs inheritance.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Audited the codebase for this and other inherited attributes that
    
  needed to be static.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix defaults() to always be static.
     
We had a number of classes where `defaults` was not properly defined as
`static`. This broke when updating to the newer `spina` that fixes
`prototypeAttrs` inheritance.

Testing Done:
- Ran js-tests.
- Audited the codebase for this and other inherited attributes that
  needed to be static.

    

   
  		
  25d9d35c12bc4b97dfd3643dc93ecebb4698922f
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/common/models/userSessionModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/models/tests/extraDataModelTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/baseCommentModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/draftReviewModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/fileAttachmentModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/reviewModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/reviewReplyModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/dndUploaderView.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...