• 
  
    
 
    
 
    

    



    
    
    
    
     
    






    
 
    


 
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Fix defaults() to always be static.
    
 
    

    



 
    
 
    

  Review Request #13517
  —
  Created Feb. 1, 2024 and submitted  — Latest diff uploaded 

 
    


    




    




    




 
    
  
    
   Information

  
    



    
 
 
    
  david
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  master
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    We had a number of classes where defaults was not properly defined as
    
static. This broke when updating to the newer spina that fixes
    
prototypeAttrs inheritance.
    
 
    

    





  

    
 
 
    
  
      

    • Ran js-tests.
      • 

    • Audited the codebase for this and other inherited attributes that
      
  needed to be static.
      • 

    
 
    

    




 
    

    





    
 
    









 




 
    

    




   
    
    
    
    
    
    
    
    

    
    
      
    Commits
    
      
    
        
      
    
    
    

    
    

      
    Files