Don't attempt an implicit unattended install when outputting to a file.

 






 

 


  Review Request #13506
  —
  Created Jan. 21, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  rbinstall
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
When running the installer with output piped to a file (or otherwise not

writing to a terminal), the installer would accept all defaults for

prompts and then initiate the install. This may not be what people want.


We now require --noinput in order to do an unattended install. When

outputting to a non-terminal without passing --noinput, the installer

will exit with an error containing instructions.

 








  


 
 

  
Tested the results when piping to a file.


Tested default attended installs and unattended with --noinput.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Don't attempt an implicit unattended install when outputting to a file.
     
When running the installer with output piped to a file (or otherwise not
writing to a terminal), the installer would accept all defaults for
prompts and then initiate the install. This may not be what people want.

We now require `--noinput` in order to do an unattended install. When
outputting to a non-terminal without passing `--noinput`, the installer
will exit with an error containing instructions.

    

   
  		
  fbff13203359b4826f6e6f33504e19aafb9fc361
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbinstall/main.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...