This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-7.x (a1130da)

Summary

Remove obsolete enableRetinaImages usage.

Review Request #13495 — Created Jan. 9, 2024 and submitted 1 year, 4 months ago — Latest diff uploaded 1 year, 5 months ago

Information

Owner

david*

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description*

All the browsers we support now have native support for srcset, so our
old Djblets.enableRetinaImages method is a no-op. This change gets rid
of those calls.

Testing Done


Ran unit tests.
Verified that I still saw high-res versions of icons and file attachment

  thumbnails.

Diff Revision 1 (Latest)

Commits

First	Last	Summary	ID	Author
		Remove obsolete enableRetinaImages usage. All the browsers we support now have native support for `srcset`, so our old `Djblets.enableRetinaImages` method is a no-op. This change gets rid of those calls. Testing Done: - Ran unit tests. - Verified that I still saw high-res versions of icons and file attachment thumbnails.	006b24455ef5e9e988552f659aeee717f72d2564	David Trowbridge

Files

	reviewboard/static/rb/js/init.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/issueSummaryTableView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyEditorView.es6.js
	reviewboard/static/rb/js/reviews/views/fileAttachmentThumbnailView.ts
	reviewboard/templates/js/tests_base.html

reviewboard/static/rb/js/init.es6.js

reviewboard/static/rb/js/reviewRequestPage/views/issueSummaryTableView.es6.js

reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyEditorView.es6.js

reviewboard/static/rb/js/reviews/views/fileAttachmentThumbnailView.ts

reviewboard/templates/js/tests_base.html