flake8
passed.
JSHint
passed.
Review Request #13491 — Created Jan. 8, 2024 and discarded
From a very early time, we had a few things that Djblets monkey-patched
into the standard String class for JS code. This change gets rid of the
use of those in the RB codebase:
String.trim()
is a standard-library method that does what ourString.strip()
method did._.escape()
and _.unescape()
do what our String.htmlEncode()
andString.htmlDecode()
methods did (plus are slightly more complete).String.stripTags()
was only used in one place, which was alreadyString.truncate()
wasn't used anywhere.Ran js-tests.
Summary | ID |
---|---|
b4a4809f6c2f0bd57f9456a5a01c5c68d00c4dc8 |
Description | From | Last Updated |
---|---|---|
All these methods but truncate are still in use in Review Board. Could also be used in extensions. I'm kinda … |
chipx86 |