Get rid of XHTML tags in JS.

Review Request #13459 — Created Dec. 21, 2023 and submitted — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

We recently ran into a bug caused by XHTML style self-closing tags used
from JS. Only one of the ones in this change could actually cause a bug,
but since all our pages claim to be HTML5 now, there's no reason to be
using this style at all.

Ran js-tests.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Get rid of XHTML tags in JS.
We recently ran into a bug caused by XHTML style self-closing tags used from JS. Only one of the ones in this change could actually cause a bug, but since all our pages claim to be HTML5 now, there's no reason to be using this style at all. Testing Done: Ran js-tests.
82e03a8787fd6d564430ee6c69295067ea7eaf49 David Trowbridge
This diff has been split across 3 pages: < 1 2 3 >
reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewViewTests.es6.js
reviewboard/static/rb/js/reviews/views/diffComplexityIconView.ts
reviewboard/static/rb/js/reviews/views/diffFileIndexView.ts
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts
reviewboard/static/rb/js/reviews/views/reviewRequestActions.ts
reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts
reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts
reviewboard/static/rb/js/reviews/views/reviewablePageView.ts
reviewboard/static/rb/js/reviews/views/tests/diffViewerPageViewTests.ts
reviewboard/static/rb/js/reviews/views/tests/fileAttachmentThumbnailViewTests.ts
reviewboard/static/rb/js/reviews/views/tests/reviewRequestEditorViewTests.ts
reviewboard/static/rb/js/reviews/views/tests/reviewRequestFieldViewsTests.ts
reviewboard/static/rb/js/reviews/views/tests/reviewablePageViewTests.ts
reviewboard/static/rb/js/ui/views/dialogView.es6.js
reviewboard/static/rb/js/ui/views/floatingBannerView.ts
reviewboard/static/rb/js/ui/views/inlineEditorView.ts
reviewboard/static/rb/js/ui/views/tests/dateInlineEditorViewTests.ts
reviewboard/static/rb/js/ui/views/tests/dateTimeInlineEditorViewTests.ts
reviewboard/static/rb/js/ui/views/tests/infoboxManagerViewTests.es6.js
reviewboard/static/rb/js/ui/views/tests/scrollManagerViewTests.es6.js
This diff has been split across 3 pages: < 1 2 3 >
Loading...