Get rid of XHTML tags in JS.

Review Request #13459 — Created Dec. 21, 2023 and submitted — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

We recently ran into a bug caused by XHTML style self-closing tags used
from JS. Only one of the ones in this change could actually cause a bug,
but since all our pages claim to be HTML5 now, there's no reason to be
using this style at all.

Ran js-tests.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Get rid of XHTML tags in JS.
We recently ran into a bug caused by XHTML style self-closing tags used from JS. Only one of the ones in this change could actually cause a bug, but since all our pages claim to be HTML5 now, there's no reason to be using this style at all. Testing Done: Ran js-tests.
82e03a8787fd6d564430ee6c69295067ea7eaf49 David Trowbridge
This diff has been split across 3 pages: 1 2 3 >
reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js
reviewboard/static/rb/js/admin/repositoryform.es6.js
reviewboard/static/rb/js/admin/views/supportBannerView.es6.js
reviewboard/static/rb/js/admin/views/webhookFormView.es6.js
reviewboard/static/rb/js/common/models/tests/commChannelModelTests.ts
reviewboard/static/rb/js/common/resources/models/tests/baseResourceModelTests.ts
reviewboard/static/rb/js/common/views/tests/pageViewTests.ts
reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.es6.js
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js
reviewboard/static/rb/js/diffviewer/views/tests/diffCommitListViewTests.es6.js
reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.es6.js
reviewboard/static/rb/js/models/uploadDiffModel.es6.js
reviewboard/static/rb/js/newReviewRequest/views/newReviewRequestView.es6.js
reviewboard/static/rb/js/newReviewRequest/views/postCommitView.es6.js
reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.es6.js
reviewboard/static/rb/js/pages/views/dashboardView.es6.js
reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.ts
reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewEntryViewTests.es6.js
reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewReplyEditorViewTests.es6.js
reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewRequestPageViewTests.es6.js
This diff has been split across 3 pages: 1 2 3 >
Loading...