Summary

Get rid of XHTML tags in JS.

Review Request #13459 — Created Dec. 21, 2023 and submitted Dec. 29, 2023, 12:27 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We recently ran into a bug caused by XHTML style self-closing tags used
from JS. Only one of the ones in this change could actually cause a bug,
but since all our pages claim to be HTML5 now, there's no reason to be
using this style at all.

Testing Done

Ran js-tests.

Commits

Summary	ID
Get rid of XHTML tags in JS. We recently ran into a bug caused by XHTML style self-closing tags used from JS. Only one of the ones in this change could actually cause a bug, but since all our pages claim to be HTML5 now, there's no reason to be using this style at all. Testing Done: Ran js-tests.	82e03a8787fd6d564430ee6c69295067ea7eaf49

Issues

Description	From	Last Updated
These should really be <%-. Maybe worth doing as a separate change, but we should fix this.	chipx86	Dec. 28, 2023, 1:01 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

reviewboard/static/rb/js/reviews/views/reviewDialogView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
These should really be <%-. Maybe worth doing as a separate change, but we should fix this.
```

Status:: Completed
Change Summary:: Pushed to release-6.x (20d3193)