flake8
passed.
JSHint
passed.
Review Request #13454 — Created Dec. 13, 2023 and submitted
Historically, Djblets has used the
publicsuffixmodule to compute the
correct public sufix for a domain (e.g.,example.comfrom
www.example.com). This module is now deprecated, replaced by a modern
publicsuffixlistmodule, which has wider Python support and a built-in
data file.We now use this module, which is fairly close to a drop-in replacement
(it actually has a compatible interface forpublicsuffixusers, but
it's trivial to migrate to the modern API).We also now cache the instance, to avoid having to load and parse every
time we're checking a DMARC record.
Unit tests pass.
| Summary | ID |
|---|---|
| e34804e98ceeb1fdde1b5d11c566004e3f0e8d63 |
Removed unused imports.
| Summary | ID | |
|---|---|---|
| eef6d9fa24aa8f3854e839d80ff4bd11a998a435 | ||
| e34804e98ceeb1fdde1b5d11c566004e3f0e8d63 |
Revision 2 (+30 -108)