Summary

Sandbox caching issues in the ratelimit code.

Review Request #13447 — Created Dec. 4, 2023 and submitted Dec. 7, 2023, 2:30 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

If the cache server misbehaves, it can break API or authentication
calls, due to the rate limit code depending on the cache server.

We now sandbox these calls, logging errors when problems occur. This
effectively disables rate limiting, but helps ensure the service can
still be used.

Testing Done

Djblets and Review Board unit tests pass.

Commits

Summary	ID
Sandbox caching issues in the ratelimit code. If the cache server misbehaves, it can break API or authentication calls, due to the rate limit code depending on the cache server. We now sandbox these calls, logging errors when problems occur. This effectively disables rate limiting, but helps ensure the service can still be used.	30eb7723bc0992edbdaabdacde285daf58b7a41c

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.x (cbcee51)