• 
      

    Add testing utilities for building Review expected queries.

    Review Request #13415 — Created Nov. 15, 2023 and submitted

    Information

    Review Board
    release-5.0.x

    Reviewers

    This introduces reviewboard.reviews.testing.queries.reviews, which
    provides the following functions for building expected queries and
    Q-expressions:

    • get_reviews_accessible_q()
    • get_reviews_accessible_equeries()
    • get_reviews_from_user_q()
    • get_reviews_from_user_equeries()

    This covers all the queries made in ReviewManager, giving us what we
    need for any unit tests that need to check accessible reviews.

    The ReviewManager unit tests have been updated to use these,
    simplifying that code considerably.

    Unit tests pass.

    Summary ID
    Add testing utilities for building Review expected queries.
    This introduces `reviewboard.reviews.testing.queries.reviews`, which provides the following functions for building expected queries and Q-expressions: * `get_reviews_accessible_q()` * `get_reviews_accessible_equeries()` * `get_reviews_from_user_q()` * `get_reviews_from_user_equeries()` This covers all the queries made in `ReviewManager`, giving us what we need for any unit tests that need to check accessible reviews. The `ReviewManager` unit tests have been updated to use these, simplifying that code considerably.
    7008df12bc61c68aac623c31b0c26bc2e8ee51f8
    Description From Last Updated

    Typo: "use used"

    maubinmaubin
    david
    1. Ship It!
    2. 
        
    maubin
    1. 
        
    2. Show all issues

      Typo: "use used"

    3. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-5.0.x (5f197a3)