Add expected query utilities for common tests, accounts and Local Sites.

Review Request #13411 — Created Nov. 9, 2023 and submitted — Latest diff uploaded

Information

Review Board
release-5.0.x

Reviewers

This introduces some new utility functions for generating common
expected queries:

  • reviewboard.accounts.testing.queries:

    • get_user_by_pk_equeries()
    • get_user_local_site_profile_equeries()
    • get_user_profile_equeries()
  • reviewboard.site.testing.queries:

    • get_local_site_by_name_equeries()
    • get_local_site_is_accessible_by_equeries()
    • get_local_site_is_mutable_by_equeries()
    • get_check_local_site_access_equeries()
  • reviewboard.testing.queries.http:

    • get_http_request_user_equeries()
    • get_http_request_start_equeries()

Most of these perform simple checks used at the start of most view
handling. They'll be used for some in-progress test updates, and will
likely be expanded as the equery library grows.

It also introduces a common type for functions that return
Q-expressions: reviewboard.testing.queries.base.ExpectedQResult. This
helps ensure consistent results and typing for these sorts of functions.

In-progress unit tests pass.

Changes between revision 2 and 3

orig
1
2
3
4

Commits

Summary ID Author
Add expected query utilities for common tests, accounts and Local Sites.
This introduces some new utility functions for generating common expected queries: * `reviewboard.accounts.testing.queries`: * `get_user_by_pk_equeries()` * `get_user_local_site_profile_equeries()` * `get_user_profile_equeries()` * `reviewboard.site.testing.queries`: * `get_local_site_by_name_equeries()` * `get_local_site_is_accessible_by_equeries()` * `get_local_site_is_mutable_by_equeries()` * `get_check_local_site_access_equeries()` * `reviewboard.testing.queries.http`: * `get_http_request_user_equeries()` * `get_http_request_start_equeries()` Most of these perform simple checks used at the start of most view handling. They'll be used for some in-progress test updates, and will likely be expanded as the equery library grows. It also introduces a common type for functions that return Q-expressions: `reviewboard.testing.queries.base.ExpectedQResult`. This helps ensure consistent results and typing for these sorts of functions.
2c871643e16d716fee8fd10d59c6656895d9aefa Christian Hammond
Add expected query utilities for common tests, accounts and Local Sites.
This introduces some new utility functions for generating common expected queries: * `reviewboard.accounts.testing.queries`: * `get_user_by_pk_equeries()` * `get_user_local_site_profile_equeries()` * `get_user_profile_equeries()` * `reviewboard.site.testing.queries`: * `get_local_site_by_name_equeries()` * `get_local_site_is_accessible_by_equeries()` * `get_local_site_is_mutable_by_equeries()` * `get_check_local_site_access_equeries()` * `reviewboard.testing.queries.http`: * `get_http_request_user_equeries()` * `get_http_request_start_equeries()` Most of these perform simple checks used at the start of most view handling. They'll be used for some in-progress test updates, and will likely be expanded as the equery library grows. It also introduces a common type for functions that return Q-expressions: `reviewboard.testing.queries.base.ExpectedQResult`. This helps ensure consistent results and typing for these sorts of functions.
612531ef5833125d19442fdff5e11cb43833d08b Christian Hammond
docs/manual/extending/coderef/index.rst
reviewboard/site/testing/queries.py
Loading...