Summary

Add expected queries and enhance tests for Repository access queries.

Review Request #13409 — Created Nov. 8, 2023 and submitted Dec. 2, 2023, 5:35 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This adds pre-built expected queries for:

Repository.objects.accessible()
Repository.objects.accessible_ids()

These functions live in reviewboard.scmtools.testing.queries, and can
be reused throughout our test suite. It's written in a verbose manner
that ensures we only ever test against finalized Q expressions, to
minimize chances of regressions or unexpected behavior.

The unit tests for .accessible() and .accessible_ids() have been
completely rewritten. They now check against these expected queries, but
they've also been expanded considerably to more thoroughly check access
with positive and negative test data, to better catch regressions. The
approach being used here will be carried over to other accessibility
tests for the next batch of this peformance work.

Testing Done

Unit tests pass.

Commits

Summary	ID
Add expected queries and enhance tests for Repository access queries. This adds pre-built expected queries for: * `Repository.objects.accessible()` * `Repository.objects.accessible_ids()` These functions live in `reviewboard.scmtools.testing.queries`, and can be reused throughout our test suite. It's written in a verbose manner that ensures we only ever test against finalized Q expressions, to minimize chances of regressions or unexpected behavior. The unit tests for `.accessible()` and `.accessible_ids()` have been completely rewritten. They now check against these expected queries, but they've also been expanded considerably to more thoroughly check access with positive and negative test data, to better catch regressions. The approach being used here will be carried over to other accessibility tests for the next batch of this peformance work.	c9d92274c8bd4324b397be9aaacca4ba12864433

Summary

Add expected queries and enhance tests for Repository access queries.

This adds pre-built expected queries for: * `Repository.objects.accessible()` * `Repository.objects.accessible_ids()` These functions live in `reviewboard.scmtools.testing.queries`, and can be reused throughout our test suite. It's written in a verbose manner that ensures we only ever test against finalized Q expressions, to minimize chances of regressions or unexpected behavior. The unit tests for `.accessible()` and `.accessible_ids()` have been completely rewritten. They now check against these expected queries, but they've also been expanded considerably to more thoroughly check access with positive and negative test data, to better catch regressions. The approach being used here will be carried over to other accessibility tests for the next batch of this peformance work.

c9d92274c8bd4324b397be9aaacca4ba12864433

Issues

Description	From	Last Updated
'typing.Optional' imported but unused Column: 1 Error code: F401	reviewbot	Nov. 8, 2023, 2:36 a.m.
'django.contrib.auth.models.Permission' imported but unused Column: 1 Error code: F401	reviewbot	Nov. 8, 2023, 2:36 a.m.
'reviewboard.accounts.models.LocalSiteProfile' imported but unused Column: 1 Error code: F401	reviewbot	Nov. 8, 2023, 2:36 a.m.
'reviewboard.accounts.models.Profile' imported but unused Column: 1 Error code: F401	reviewbot	Nov. 8, 2023, 2:36 a.m.
'reviewboard.reviews.models.Group' imported but unused Column: 1 Error code: F401	reviewbot	Nov. 8, 2023, 2:36 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/scmtools/testing/queries.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'typing.Optional' imported but unused

Column: 1
Error code: F401
```
reviewboard/scmtools/testing/queries.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'django.contrib.auth.models.Permission' imported but unused

Column: 1
Error code: F401
```

reviewboard/scmtools/testing/queries.py (Diff revision 1)

The issue has been resolved. Show all issues

'reviewboard.accounts.models.LocalSiteProfile' imported but unused

Column: 1
Error code: F401

reviewboard/scmtools/testing/queries.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'reviewboard.accounts.models.Profile' imported but unused

Column: 1
Error code: F401
```
reviewboard/scmtools/testing/queries.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'reviewboard.reviews.models.Group' imported but unused

Column: 1
Error code: F401
```

Change Summary:

Removed unused imports.

Commits:

	Summary	ID
	Add expected queries and enhance tests for Repository access queries. This adds pre-built expected queries for: * `Repository.objects.accessible()` * `Repository.objects.accessible_ids()` These functions live in `reviewboard.scmtools.testing.queries`, and can be reused throughout our test suite. It's written in a verbose manner that ensures we only ever test against finalized Q expressions, to minimize chances of regressions or unexpected behavior. The unit tests for `.accessible()` and `.accessible_ids()` have been completely rewritten. They now check against these expected queries, but they've also been expanded considerably to more thoroughly check access with positive and negative test data, to better catch regressions. The approach being used here will be carried over to other accessibility tests for the next batch of this peformance work.	d54843e8fc86bc0f02b56cbb6bfcd8d194ba8da8
	Add expected queries and enhance tests for Repository access queries. This adds pre-built expected queries for: * `Repository.objects.accessible()` * `Repository.objects.accessible_ids()` These functions live in `reviewboard.scmtools.testing.queries`, and can be reused throughout our test suite. It's written in a verbose manner that ensures we only ever test against finalized Q expressions, to minimize chances of regressions or unexpected behavior. The unit tests for `.accessible()` and `.accessible_ids()` have been completely rewritten. They now check against these expected queries, but they've also been expanded considerably to more thoroughly check access with positive and negative test data, to better catch regressions. The approach being used here will be carried over to other accessibility tests for the next batch of this peformance work.	9f6633a53ca2bd96e587880e8b15b26d80ddb5ce

Diff:

Revision 2 (+3116 -618)

Show changes

	docs/manual/extending/coderef/index.rst
	reviewboard/scmtools/testing/__init__.py
	reviewboard/scmtools/testing/queries.py
	reviewboard/scmtools/tests/test_repository_manager.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:

Added missing __note__ values.

Commits:

	Summary	ID
	Add expected queries and enhance tests for Repository access queries. This adds pre-built expected queries for: * `Repository.objects.accessible()` * `Repository.objects.accessible_ids()` These functions live in `reviewboard.scmtools.testing.queries`, and can be reused throughout our test suite. It's written in a verbose manner that ensures we only ever test against finalized Q expressions, to minimize chances of regressions or unexpected behavior. The unit tests for `.accessible()` and `.accessible_ids()` have been completely rewritten. They now check against these expected queries, but they've also been expanded considerably to more thoroughly check access with positive and negative test data, to better catch regressions. The approach being used here will be carried over to other accessibility tests for the next batch of this peformance work.	9f6633a53ca2bd96e587880e8b15b26d80ddb5ce
	Add expected queries and enhance tests for Repository access queries. This adds pre-built expected queries for: * `Repository.objects.accessible()` * `Repository.objects.accessible_ids()` These functions live in `reviewboard.scmtools.testing.queries`, and can be reused throughout our test suite. It's written in a verbose manner that ensures we only ever test against finalized Q expressions, to minimize chances of regressions or unexpected behavior. The unit tests for `.accessible()` and `.accessible_ids()` have been completely rewritten. They now check against these expected queries, but they've also been expanded considerably to more thoroughly check access with positive and negative test data, to better catch regressions. The approach being used here will be carried over to other accessibility tests for the next batch of this peformance work.	c9d92274c8bd4324b397be9aaacca4ba12864433

Diff:

Revision 3 (+3124 -618)

Show changes

	docs/manual/extending/coderef/index.rst
	reviewboard/scmtools/testing/__init__.py
	reviewboard/scmtools/testing/queries.py
	reviewboard/scmtools/tests/test_repository_manager.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.0.x (4395857)