Summary

Discussion: auto-formatting (reviews).

Review Request #13381 — Created Oct. 26, 2023 and discarded Dec. 26, 2023, 10:39 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This is here to facilitate our discussion about potentially adopting
auto-formatting for our codebase. This change uses black to format the
reviews app with the following settings:

[tool.black]
line-length = 80
target-version = ['py38', 'py39', 'py310', 'py311', 'py312']
skip-string-normalization = true

Testing Done

Commits

Summary	ID
Discussion: auto-formatting (reviews). This is here to facilitate our discussion about potentially adopting auto-formatting for our codebase. This change uses `black` to format the `reviews` app with the following settings: ``` [tool.black] line-length = 80 target-version = ['py38', 'py39', 'py310', 'py311', 'py312'] skip-string-normalization = true ```	70c44a4a38cb7f9bacf94fe54312f4ab04e7543f

Issues

Description	From	Last Updated
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 17 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 21 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 21 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:22 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:23 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:23 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:23 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:23 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:23 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:23 p.m.
line break before binary operator Column: 13 Error code: W503	reviewbot	Oct. 26, 2023, 3:23 p.m.

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 97 failures.
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 17
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 21
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 21
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```
reviewboard/reviews/actions.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 13
Error code: W503
```

Status:: Discarded