Summary

Expand the Local Site query checks in the Groups datagrid tests.

Review Request #13362 — Created Oct. 22, 2023 and submitted Oct. 27, 2023, 6:11 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

~~13360~~

Reviewers

Groups

reviewboard

People

Description

This splits most of the unit tests in the Groups datagrid test suite
into a global site test, a Local Site test, and a global site + Local
Sites in the database test.

This gives us thorough query coverage, which unveils a number of
sub-optimal queries that will need to be addressed in upcoming changes.

The queries are intentionally verbose right now, with no query-building
being shared across tests, and with the query-by-query breakdowns
removed. This is intentional, as upcoming work is expected to heavily
impact these queries.

Testing Done

Unit tests pass.

Commits

Summary	ID
Expand the Local Site query checks in the Groups datagrid tests. This splits most of the unit tests in the Groups datagrid test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.	35bdf5d4b3de2e2fd0df9b8b4a612900b5344b6c

Summary

Expand the Local Site query checks in the Groups datagrid tests.

This splits most of the unit tests in the Groups datagrid test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.

35bdf5d4b3de2e2fd0df9b8b4a612900b5344b6c

flake8 passed.

JSHint passed.

Change Summary:


Alphabetized query match keys.
Fixed docs to say "groups datagrid" and not "users datagrid".

Commits:

	Summary	ID
	Expand the Local Site query checks in the Groups datagrid tests. This splits most of the unit tests in the Groups datagrid test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.	3f7776b1ab21e67d11833ab91e7440ee343022fc
	Expand the Local Site query checks in the Groups datagrid tests. This splits most of the unit tests in the Groups datagrid test suite into a global site test, a Local Site test, and a global site + Local Sites in the database test. This gives us thorough query coverage, which unveils a number of sub-optimal queries that will need to be addressed in upcoming changes. The queries are intentionally verbose right now, with no query-building being shared across tests, and with the query-by-query breakdowns removed. This is intentional, as upcoming work is expected to heavily impact these queries.	35bdf5d4b3de2e2fd0df9b8b4a612900b5344b6c

Diff:

Revision 2 (+414 -290)

Show changes

reviewboard/datagrids/tests/test_groups_list.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.0.x (e69a51d)