Summary

Update review queries to query Local Sites conditionally.

Review Request #13357 — Created Oct. 18, 2023 and submitted Oct. 25, 2023, 9:41 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

~~13356~~

Reviewers

Groups

reviewboard

People

Description

Review Board 5 introduced some mechanisms for optimizing queries to
avoid filering by Local Sites if there aren't any Local Sites in the
database. We updated a few queries to use this, but not all.

This change updates ReviewManager to take advantage of this, reducing
the complexity of queries and helping the database better use its
indexes on a typical install.

There's also a fix for building queries for Local Sites, taking
advantage of the field name provided.

This is the first in a series of changes for optimizing Local Site
filters out of queries.

Testing Done

All unit tests pass.

Commits

Summary	ID
Update review queries to query Local Sites conditionally. Review Board 5 introduced some mechanisms for optimizing queries to avoid filering by Local Sites if there aren't any Local Sites in the database. We updated a few queries to use this, but not all. This change updates `ReviewManager` to take advantage of this, reducing the complexity of queries and helping the database better use its indexes on a typical install. There's also a fix for building queries for Local Sites, taking advantage of the field name provided. This is the first in a series of changes for optimizing Local Site filters out of queries.	c6f57ceec9b7747c264759ee3f0fac8e41932259

Summary

Update review queries to query Local Sites conditionally.

Review Board 5 introduced some mechanisms for optimizing queries to avoid filering by Local Sites if there aren't any Local Sites in the database. We updated a few queries to use this, but not all. This change updates `ReviewManager` to take advantage of this, reducing the complexity of queries and helping the database better use its indexes on a typical install. There's also a fix for building queries for Local Sites, taking advantage of the field name provided. This is the first in a series of changes for optimizing Local Site filters out of queries.

c6f57ceec9b7747c264759ee3f0fac8e41932259

Issues

Description	From	Last Updated
local variable 'local_site_q' is assigned to but never used Column: 13 Error code: F841	reviewbot	Oct. 18, 2023, 1:50 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_review_manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
local variable 'local_site_q' is assigned to but never used

Column: 13
Error code: F841
```

Change Summary:

Removed an unused variable.

Commits:

	Summary	ID
	Update review queries to query Local Sites conditionally. Review Board 5 introduced some mechanisms for optimizing queries to avoid filering by Local Sites if there aren't any Local Sites in the database. We updated a few queries to use this, but not all. This change updates `ReviewManager` to take advantage of this, reducing the complexity of queries and helping the database better use its indexes on a typical install. There's also a fix for building queries for Local Sites, taking advantage of the field name provided. This is the first in a series of changes for optimizing Local Site filters out of queries.	5caea929639bebfdb73a86c8b9cdfa4830b794b8
	Update review queries to query Local Sites conditionally. Review Board 5 introduced some mechanisms for optimizing queries to avoid filering by Local Sites if there aren't any Local Sites in the database. We updated a few queries to use this, but not all. This change updates `ReviewManager` to take advantage of this, reducing the complexity of queries and helping the database better use its indexes on a typical install. There's also a fix for building queries for Local Sites, taking advantage of the field name provided. This is the first in a series of changes for optimizing Local Site filters out of queries.	c6f57ceec9b7747c264759ee3f0fac8e41932259

Diff:

Revision 2 (+202 -74)

Show changes

	reviewboard/datagrids/tests.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/tests/test_review_manager.py
	reviewboard/site/managers.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.0.x (344e6ca)