Summary

Prepare ReviewManager tests for upcoming query improvements.

Review Request #13356 — Created Oct. 18, 2023 and submitted Oct. 25, 2023, 9:31 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Blocks

13357

Reviewers

Groups

reviewboard

People

Description

This reworks the code in test_review_manager.py to allow more of the
queries and the test setup to be shared. We now have tests for the
global site, Local Sites, and the global site when there are Local Sites
in the database.

Upcoming work on review queries will take advantage of this to check
queries based on the various Local Site conditions.

Testing Done

Unit tests pass.

Commits

Summary	ID
Prepare ReviewManager tests for upcoming query improvements. This reworks the code in `test_review_manager.py` to allow more of the queries and the test setup to be shared. We now have tests for the global site, Local Sites, and the global site when there are Local Sites in the database. Upcoming work on review queries will take advantage of this to check queries based on the various Local Site conditions.	0b8dcb51ed94435e9d07c03e5e380c0d86f70962

Summary

Prepare ReviewManager tests for upcoming query improvements.

This reworks the code in `test_review_manager.py` to allow more of the queries and the test setup to be shared. We now have tests for the global site, Local Sites, and the global site when there are Local Sites in the database. Upcoming work on review queries will take advantage of this to check queries based on the various Local Site conditions.

0b8dcb51ed94435e9d07c03e5e380c0d86f70962

Issues

Description	From	Last Updated
local variable 'anonymous' is assigned to but never used Column: 9 Error code: F841	reviewbot	Oct. 18, 2023, 1:21 p.m.
local variable 'superuser' is assigned to but never used Column: 9 Error code: F841	reviewbot	Oct. 18, 2023, 1:21 p.m.

flake8 passed.

JSHint passed.

Change Summary:


Extracted the from_user test logic into a test helper.
Added Local Site variations to the public, from_user, and extra_query tests.

Commits:

	Summary	ID
	Prepare ReviewManager tests for upcoming query improvements. This reworks the code in `test_review_manager.py` to allow more of the queries and the test setup to be shared. We now have tests for the global site, Local Sites, and the global site when there are Local Sites in the database. Upcoming work on review queries will take advantage of this to check queries based on the various Local Site conditions.	5a46e84a548ce5e04504e23782a0b5d3e34bb492
	Prepare ReviewManager tests for upcoming query improvements. This reworks the code in `test_review_manager.py` to allow more of the queries and the test setup to be shared. We now have tests for the global site, Local Sites, and the global site when there are Local Sites in the database. Upcoming work on review queries will take advantage of this to check queries based on the various Local Site conditions.	a8ccbf3d6eacd4b5d7e905b69c1a25787c842fff

Diff:

Revision 2 (+2434 -2052)

Show changes

reviewboard/reviews/tests/test_review_manager.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_review_manager.py (Diff revision 2)
The issue has been resolved. Show all issues
```
local variable 'anonymous' is assigned to but never used

Column: 9
Error code: F841
```
reviewboard/reviews/tests/test_review_manager.py (Diff revision 2)
The issue has been resolved. Show all issues
```
local variable 'superuser' is assigned to but never used

Column: 9
Error code: F841
```

Change Summary:

Removed unused variables.

Commits:

	Summary	ID
	Prepare ReviewManager tests for upcoming query improvements. This reworks the code in `test_review_manager.py` to allow more of the queries and the test setup to be shared. We now have tests for the global site, Local Sites, and the global site when there are Local Sites in the database. Upcoming work on review queries will take advantage of this to check queries based on the various Local Site conditions.	a8ccbf3d6eacd4b5d7e905b69c1a25787c842fff
	Prepare ReviewManager tests for upcoming query improvements. This reworks the code in `test_review_manager.py` to allow more of the queries and the test setup to be shared. We now have tests for the global site, Local Sites, and the global site when there are Local Sites in the database. Upcoming work on review queries will take advantage of this to check queries based on the various Local Site conditions.	0b8dcb51ed94435e9d07c03e5e380c0d86f70962

Diff:

Revision 3 (+2430 -2052)

Show changes

reviewboard/reviews/tests/test_review_manager.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.0.x (45c6c1f)