Summary

Fix the display of the comment dialog on mobile devices.

Review Request #13311 — Created Oct. 5, 2023 and submitted Oct. 10, 2023, 2:03 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

With this change, invoking the comment dialog will now properly display
it within the bounds of the viewport, allowing the user to leave a
comment and then save it without having to work around the viewport or
size.

Testing Done

Tested on desktop, responsive mode on Chrome and Firefox, and on iOS 17.

Commits

Summary	ID
Fix the display of the comment dialog on mobile devices. This updates the comment dialog to have a maximum width that fits cleanly within the browser's viewport, with some spacing on the side. This is there for mobile, where the comment dialog's default width would easily overflow the page. With this change, invoking the comment dialog will now properly display it within the bounds of the viewport, allowing the user to leave a comment and then save it without having to work around the viewport or size.	b52badaffb239a643bf1fca5dc894cbce655d25e

Summary

Fix the display of the comment dialog on mobile devices.

This updates the comment dialog to have a maximum width that fits cleanly within the browser's viewport, with some spacing on the side. This is there for mobile, where the comment dialog's default width would easily overflow the page. With this change, invoking the comment dialog will now properly display it within the bounds of the viewport, allowing the user to leave a comment and then save it without having to work around the viewport or size.

b52badaffb239a643bf1fca5dc894cbce655d25e

Files

Issues

Description	From	Last Updated
typo: sizibg	david	Oct. 8, 2023, 12:46 p.m.

flake8 passed.

JSHint passed.

Added Files:

reviewboard/static/rb/css/pages/reviews.less (Diff revision 1)
The issue has been resolved. Show all issues
```
typo: sizibg
```

Ship it!

```
Good to go other than the typo.
```

Change Summary:

Fixed a typo in box-sizing.

Commits:

	Summary	ID
	Fix the display of the comment dialog on mobile devices. This updates the comment dialog to have a maximum width that fits cleanly within the browser's viewport, with some spacing on the side. This is there for mobile, where the comment dialog's default width would easily overflow the page. With this change, invoking the comment dialog will now properly display it within the bounds of the viewport, allowing the user to leave a comment and then save it without having to work around the viewport or size.	999e1ba907b5ad53087277a88839c1ca08afcdbd
	Fix the display of the comment dialog on mobile devices. This updates the comment dialog to have a maximum width that fits cleanly within the browser's viewport, with some spacing on the side. This is there for mobile, where the comment dialog's default width would easily overflow the page. With this change, invoking the comment dialog will now properly display it within the bounds of the viewport, allowing the user to leave a comment and then save it without having to work around the viewport or size.	b52badaffb239a643bf1fca5dc894cbce655d25e

Diff:

Revision 2 (+6 -14)

Show changes

reviewboard/static/rb/css/pages/reviews.less

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status:: Completed
Change Summary:: Pushed to release-6.x (d342c7e)