• 
      

    Update the docs for Docker and Nginx for latest recommendations.

    Review Request #13307 — Created Oct. 5, 2023 and submitted

    Information

    Review Board
    release-6.x

    Reviewers

    The Docker configuration now tries to do a better job of letting people
    know that the Review Board image is for a backend server, and is not
    meant to be accessed directly. This is done through repeated use of
    "frontend" vs. "backend" terminology and a big note when creating the
    image.

    The docs list newer example versions of Review Board versions, so it
    doesn't appear too ancient.

    The Nginx configuration has been updated based on the latest version of
    what we auto-generate when creating a site. The docs and the
    auto-generated configuration also have some updates based on best
    practices we've used in our own servers.

    Built the docs and read through them, looking for errors.

    Tested the Nginx configuration locally.

    Summary ID
    Update the docs for Docker and Nginx for latest recommendations.
    The Docker configuration now tries to do a better job of letting people know that the Review Board image is for a backend server, and is not meant to be accessed directly. This is done through repeated use of "frontend" vs. "backend" terminology and a big note when creating the image. The docs list newer example versions of Review Board versions, so it doesn't appear too ancient. The Nginx configuration has been updated based on the latest version of what we auto-generate when creating a site. The docs and the auto-generated configuration also have some updates based on best practices we've used in our own servers.
    47f8280e169d2bdaed24fa67f8d0543125571241
    Description From Last Updated

    Can take out the word "configure" here.

    maubinmaubin

    Is the :8080 supposed to be here? Wouldn't the command to change the port just be -p {port}?

    maubinmaubin

    Same note as deafult.conf.template file (remove "configure")

    maubinmaubin
    maubin
    1. 
        
    2. Show all issues

      Can take out the word "configure" here.

    3. Show all issues

      Is the :8080 supposed to be here? Wouldn't the command to change the port just be -p {port}?

      1. Yeah, it's a map from a chosen port to the in-container port 8080. I'll clarify the language.

    4. Show all issues

      Same note as deafult.conf.template file (remove "configure")

    5. 
        
    chipx86
    david
    1. Ship It!
    2. 
        
    maubin
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-6.x (0943929)