• 
      

    Hide the Commits field when there are no commits present.

    Review Request #13296 — Created Oct. 1, 2023 and submitted

    Information

    Review Board
    release-6.x

    Reviewers

    The Commits field on the main review request box is present even if
    there's no commits data to show. We end up with a label but no content.
    This happens because we specify the field should be always present
    unless this is on the diff viewer page (which has its own commits
    representation).

    We now factor in the value itself, ensuring that we only show the field
    if we know we're going to end up showing a list of commits.

    Tested viewing review requests with and without commits data. I could
    no longer reproduce the bug where only a Commits label was shown.

    Summary ID
    Hide the Commits field when there are no commits present.
    The Commits field on the main review request box is present even if there's no commits data to show. We end up with a label but no content. This happens because we specify the field should be always present unless this is on the diff viewer page (which has its own commits representation). We now factor in the value itself, ensuring that we only show the field if we know we're going to end up showing a list of commits.
    bc2f34e795f858c171bf0a2808a8efab77842dee
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-6.x (44e8933)