Fix a regression in collapsing the diff commit list.

Review Request #13294 — Created Sept. 29, 2023 and submitted — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

The diff commit list on the review request box regressed recently with
an event handler cleanup. Both expanding and collapsing the diff
resulted in an expanded state, as both handlers were passing true for
expand.

This updates the collapse handler to pass false, allowing collapsing
to work again.

Manually tested repeatedly expanding and collapsing the list.

Verified this fixed unit test breakages.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Fix a regression in collapsing the diff commit list.
The diff commit list on the review request box regressed recently with an event handler cleanup. Both expanding and collapsing the diff resulted in an expanded state, as both handlers were passing `true` for `expand`. This updates the collapse handler to pass `false`, allowing collapsing to work again.
08bdeeb27081ea0c4a3b01b880bebc413fbfe11e Christian Hammond
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js
Loading...