Update the API to allow undoing the pending deletion of file attachments.

 






 

 


  Review Request #13251
  —
  Created Aug. 31, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  maubin
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This updates the file attachments API update endpoints to allow undoing the

pending deletion of file attachments. We add a pending_deletion query

parameter that can only be set to False to do this.


This also reduces the number of queries performed when deleting multiple

revisions of file attachments. Instead of removing revisions one by one,

we do a batch remove which reduces this to just one query instead of

one query per revision.

 








  


 
 

  
    

  • Ran unit tests.
    • 

  • Used in an upcoming change.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 3 (Latest)



    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    
Update the API to allow undoing the pending deletion of file attachments.

   
  		
  c6879af7e21ebb928e20e101fc5faf478daa99d6
  Michelle Aubin
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/webapi/resources/base_review_request_file_attachment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/test_file_attachment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/test_file_attachment_draft.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...