Introduce file attachment states.

Review Request #13238 — Created Aug. 27, 2023 and submitted — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

Our file attachments can be in many different states, but we don't really have
a solid concept of these states in our codebase so far. We also don't have a
formal way of determining which state a file attachment is in.

This change introduces file attachment states and allows us to efficiently
get the state of a file attachment through its review request or draft.

This sets the foundation for an upcoming change that improves how we display
file attachments on a review request and how users can manage them.

  • Ran unit tests.
  • Ran JS unit tests.
  • Used in upcoming changes.

Changes between revision 2 and 3

orig
1
2
3

Commits

Summary ID Author
Introduce file attachment states.
5ec38fdc4f63e1a3a5b01abfb98c27521899a27e Michelle Aubin
Introduce file attachment states.
f81a59d3ac1b258a3dffee7a378a3d0856a7a088 Michelle Aubin
reviewboard/attachments/models.py
reviewboard/reviews/models/base_review_request_details.py
reviewboard/reviews/models/review_request.py
reviewboard/reviews/models/review_request_draft.py
reviewboard/reviews/views/mixins.py
Loading...