Introduce file attachment states.
Review Request #13238 — Created Aug. 27, 2023 and submitted — Latest diff uploaded
Our file attachments can be in many different states, but we don't really have
a solid concept of these states in our codebase so far. We also don't have a
formal way of determining which state a file attachment is in.This change introduces file attachment states and allows us to efficiently
get the state of a file attachment through its review request or draft.This sets the foundation for an upcoming change that improves how we display
file attachments on a review request and how users can manage them.
- Ran unit tests.
- Ran JS unit tests.
- Used in upcoming changes.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.
orig
1
2
3
Commits
Files
| reviewboard/attachments/models.py |
|---|
| reviewboard/reviews/builtin_fields.py |
|---|
| reviewboard/reviews/models/base_review_request_details.py |
|---|
| reviewboard/reviews/models/review_request.py |
|---|
| reviewboard/reviews/models/review_request_draft.py |
|---|
| reviewboard/reviews/tests/test_builtin_fields.py |
|---|
| reviewboard/reviews/tests/test_review_request.py |
|---|
| reviewboard/reviews/views/mixins.py |
|---|
| reviewboard/static/rb/js/common/resources/models/fileAttachmentModel.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/tests/fileAttachmentModelTests.ts |
|---|