Port FileAttachmentThumbnailView to TS/spina.

 






 

 


  Review Request #13221
  —
  Created Aug. 17, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  maubin
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This ports the FileAttachmentThumbnail view to TS/spina. The view is also

renamed to FileAttachmentThumbnailView to follow our naming conventions.

 








  


 
 

  
    

  • Ran JS unit tests.
    • 

  • Tested using/viewing file attachment thumbnails on the review request,
    
  in change descriptions, and in file review UIs.
    • 

  • Tested uploading/deleting files.
    • 

  • Tested all the file actions.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 3 and 4



    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    
Port FileAttachmentThumbnailView to TS/spina.

   
  		
  c3ac9057ac767bbb37a0a621f441cc2b9fda0a51
  Michelle Aubin
 


 
  
 
 
  
   
    
Port FileAttachmentThumbnailView to TS/spina.

   
  		
  1706815d3113af0b74b3aff33dec2ef7cb88af01
  Michelle Aubin
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/tests/fileAttachmentThumbnailViewTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/templates/reviews/changedesc_file_attachment.html
     
    

   
  

 










     

    

   

  

  

   
   Loading...